chore: add #include <string> in json_utils.h #33332
Closed
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
cjihrig
approved these changes
May 10, 2020
targos
approved these changes
May 10, 2020
richardlau
approved these changes
May 10, 2020
addaleax
added
the
author ready
jasnell
approved these changes
May 11, 2020
|
Landed in fda13d5 |
targos
pushed a commit
that referenced
this pull request
May 16, 2020
When precompile headers are disabled this file would cause compilation errors due to #include <string> not included. PR-URL: #33332 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
May 16, 2020
When precompile headers are disabled this file would cause compilation errors due to #include <string> not included. PR-URL: #33332 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 7, 2020
When precompile headers are disabled this file would cause compilation errors due to #include <string> not included. PR-URL: #33332 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
codebytere
pushed a commit
to codebytere/node
that referenced
this pull request
Jun 9, 2020
When precompile headers are disabled this file would cause compilation errors due to #include <string> not included. PR-URL: nodejs#33332 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When precompile headers are disabled this file would cause compilation errors due to
#include <string>not included.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes